Uploaded image for project: 'Beam'
  1. Beam
  2. BEAM-13239

[Go SDK] Schema Row Decoder doesn't properly handle io.EOF

Details

    • Bug
    • Status: Resolved
    • P2
    • Resolution: Fixed
    • 2.33.0, 2.34.0
    • 2.35.0
    • sdk-go
    • None

    Description

      The Schema Row Decoder doesn't properly handle io.EOF errors, and ends up incorrectly wrapping them. This breaks Iterable processing which checks for io.EOF (generally common for all go io processing really).

      https://github.com/apache/beam/blob/master/sdks/go/pkg/beam/core/graph/coder/row_decoder.go#L108

      Simple fix. Needs to check for io.EOF first, before re-wrapping.

      errors.Wrapf ignores nils and returns a nil in when passed one, so it's immeadiate use is fine.

      Attachments

        Issue Links

          Activity

            People

              lostluck Robert Burke
              lostluck Robert Burke
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 0.5h
                  0.5h