Uploaded image for project: 'Beam'
  1. Beam
  2. BEAM-11727

Optimize ExecutionStateSampler

Details

    • Bug
    • Status: Resolved
    • P2
    • Resolution: Fixed
    • None
    • Missing
    • runner-core
    • None

    Description

      Showed up as 1.5% of CPU on Nexmark 11 streaming benchmark run.

      It appears to be using a ConcurrentSkipListSet and most of the cpu is relatedd to inserts/removes in that, involving the system hash of the entries as that is used for ordering.

      The consistent ordering is unnecessary. Additionally for other reasons, removal and iteration is already synchronized and so performance will likely be better just using a synchronized HashMap and synchronizing in the add case.

      Attachments

        Issue Links

          Activity

            People

              scwhittle Sam Whittle
              scwhittle Sam Whittle
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 1h 40m
                  1h 40m