Uploaded image for project: 'Beam'
  1. Beam
  2. BEAM-11212

Beam metrics should be displayed in Flink UI "Metrics" tab

Details

    • Wish
    • Status: Open
    • P1
    • Resolution: Unresolved
    • None
    • None
    • runner-flink

    Description

      All Beam metrics are visible in the Flink UI in a single accumulator value (in the "Accumulators" tab), which is a large, hard-to-read blob. Originally, this blob was rendered in a bespoke format (https://github.com/apache/beam/blob/ead80b469ffeeddcd8e9e5c8dc462eec0b0ffc6b/sdks/java/core/src/main/java/org/apache/beam/sdk/metrics/MetricQueryResults.java#L63-L72). I changed the format to JSON so it could be easily deserialized (BEAM-9600). But then an issue was filed (BEAM-10294) reporting that the new JSON format was harder to read than the original bespoke format. The temporary fix was to revert to the bespoke format in Spark, while allowing Flink to continue to use JSON. However, if Beam metrics in Flink are only visible as an accumulator, then they are also unreadable because the payloads are in binary form (BEAM-10719).

      Having metrics visible in Flink's "Metrics" tab would A) make metrics easier to read (even compared to the bespoke accumulator string format), and closer to what users of Beamless Flink expect, and B) free us to use the accumulator however we wish for Beam internal purposes, without worrying about readability.

      One question I'm not sure about is, why can't we see Beam metrics in the Flink UI already? I thought we were already translating Beam metrics into Flink native metrics (https://github.com/apache/beam/blob/ea2a3f6896b66a2852a2ff3d82f4e1b010013d13/runners/flink/src/main/java/org/apache/beam/runners/flink/metrics/FlinkMetricContainer.java#L108-L109). Is there something else we need to do to display them in the UI?

      Attachments

        1. flink-metrics.png
          368 kB
          Kyle Weaver
        2. Screenshot 2021-01-20 at 12.07.33.png
          120 kB
          Tomasz Szerszen
        3. Screenshot 2021-01-20 at 12.08.44.png
          21 kB
          Tomasz Szerszen

        Issue Links

          Activity

            People

              Unassigned Unassigned
              ibzib Kyle Weaver

              Dates

                Created:
                Updated:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 0.5h
                  0.5h

                  Slack

                    Issue deployment