Uploaded image for project: 'Beam'
  1. Beam
  2. BEAM-11144

TriggerStateMachine.prefetchOnElement and other prefetch methods use incorrect state for subtriggers

Details

    • Bug
    • Status: Resolved
    • P2
    • Resolution: Fixed
    • None
    • 2.26.0
    • runner-core
    • None

    Description

      prefetchOnElement takes a single StateAccessor corresponding to the root trigger. It uses that state accessor to perform prefetches for the subtrigger state. However that will use the root trigger namespace for the tags in the subtriggers. This makes prefetching ineffective, introducing possibly an additional round-trip once the data is actually read.

      https://github.com/apache/beam/blob/68d6c8e6243b1d8f392840273f886276e2a8baff/runners/core-java/src/main/java/org/apache/beam/runners/core/triggers/TriggerStateMachine.java#L296

      Attachments

        Issue Links

          Activity

            People

              scwhittle Sam Whittle
              scwhittle Sam Whittle
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 1h 10m
                  1h 10m