Uploaded image for project: 'Apache Avro'
  1. Apache Avro
  2. AVRO-3703

avro 1.11.1 stopped validating namespace changes on deserialization

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Open
    • Major
    • Resolution: Unresolved
    • 1.11.1
    • None
    • java
    • None

    Description

      the following test passes on 1.11.0 but fails on 1.11.1:

      @Test(expected = AvroTypeException.class)
        public void testFullnameValidation() throws Exception {
          String avsc1 =
              "{\n"
            + "  \"type\": \"record\",\n"
            + "  \"name\": \"RecordSimpleName\",\n"
            + "  \"namespace\": \"some.namespace\",\n"
            + "  \"fields\": [\n"
            + "    {\n"
            + "      \"name\" : \"enumField\",\n"
            + "      \"type\" : {\n"
            + "        \"type\" : \"enum\",\n"
            + "        \"name\" : \"InnerEnum\",\n"
            + "        \"symbols\" : [ \"THE\", \"SPEC\", \"IS\", \"A\", \"LIE\" ],\n"
            + "        \"doc\" : \"inherits no namespace so is InnerEnum\"\n"
            + "      }\n"
            + "    }\n"
            + "  ]\n"
            + "}\n";
          String avsc2 = avsc1.replace("some.namespace", "something.else");
          Schema schema1 = Schema.parse(avsc1);
          Schema schema2 = Schema.parse(avsc2);
      
          Assert.assertEquals(schema1.getName(), schema2.getName());
          Assert.assertNotEquals(schema1.getNamespace(), schema2.getNamespace());
          Assert.assertNotEquals(schema1.getFullName(), schema2.getFullName());
      
          GenericDatumReader<IndexedRecord> reader = new GenericDatumReader<>(schema1, schema2);
          JsonDecoder decoder = DecoderFactory.get().jsonDecoder(schema1, "{\"enumField\": \"LIE\"}");
      
          IndexedRecord deserialized = reader.read(null, decoder);
          Assert.fail("deserialization should have failed over namespace mismatch");
        }
      

      looks like avro 1.11.1 disregards namespace/fullnames during deserialization? (this was the behaviour under avro 1.4)

      1.11.0 produces the expected failure:

      org.apache.avro.AvroTypeException: Found some.namespace.InnerEnum, expecting something.else.InnerEnum
      
      	at org.apache.avro.io.ResolvingDecoder.doAction(ResolvingDecoder.java:308)
      	at org.apache.avro.io.parsing.Parser.advance(Parser.java:86)
      	at org.apache.avro.io.ResolvingDecoder.readEnum(ResolvingDecoder.java:259)
      	at org.apache.avro.generic.GenericDatumReader.readEnum(GenericDatumReader.java:268)
      	at org.apache.avro.generic.GenericDatumReader.readWithoutConversion(GenericDatumReader.java:182)
      	at org.apache.avro.generic.GenericDatumReader.read(GenericDatumReader.java:161)
      	at org.apache.avro.generic.GenericDatumReader.readField(GenericDatumReader.java:260)
      	at org.apache.avro.generic.GenericDatumReader.readRecord(GenericDatumReader.java:248)
      	at org.apache.avro.generic.GenericDatumReader.readWithoutConversion(GenericDatumReader.java:180)
      	at org.apache.avro.generic.GenericDatumReader.read(GenericDatumReader.java:161)
      	at org.apache.avro.generic.GenericDatumReader.read(GenericDatumReader.java:154)
      	at org.apache.avro.generic.TestFullnameEnforcement.testFullnameValidation(TestFullnameEnforcement.java:59)
      	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
      	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
      	at java.lang.reflect.Method.invoke(Method.java:498)
      	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
      	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
      	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
      	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
      	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
      	at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
      	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
      	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
      	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
      	at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
      	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
      	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
      	at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
      	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
      	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
      	at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
      	at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
      	at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:69)
      	at com.intellij.rt.junit.IdeaTestRunner$Repeater$1.execute(IdeaTestRunner.java:38)
      	at com.intellij.rt.execution.junit.TestsRepeater.repeat(TestsRepeater.java:11)
      	at com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:35)
      	at com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:235)
      	at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:54)
      

      Attachments

        Activity

          People

            Unassigned Unassigned
            radai Radai Rosenblatt
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated: