[THRIFT-3176] Union incorrectly implements == - ASF JIRA

Voters

Stop watching

Watchers

Link

Clone

Update Comment Author

Replace String in Comment

Update Comment Visibility

Delete Comments

XML

Word

Printable

JSON

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: None
Fix Version/s: 0.9.3
Component/s: Ruby - Library
Labels:
None

Patch Info:

Patch Available
Flags:

Patch

Description

If you would like to compare a String or any other objects which do not implement `get_set_field` and `get_value` it fails.

Example:

2.1.5 :003 > u = Thrift::Union.new
 => <Thrift::Union >
2.1.5 :004 > u == ''
NoMethodError: undefined method `get_set_field' for "":String
	from /Users/ikaraszi/.rvm/gems/ruby-2.1.5/gems/thrift-0.9.2.0/lib/thrift/union.rb:90:in `=='
	from (irb):4
	from /Users/ikaraszi/.rvm/rubies/ruby-2.1.5/bin/irb:11:in `<main>'