[HDFS-12218] Rename split EC / replicated block metrics in BlockManager - ASF JIRA

Voters

Stop watching

Watchers

Create sub-task

Link

Clone

Update Comment Author

Replace String in Comment

Update Comment Visibility

Delete Comments

XML

Word

Printable

JSON

Details

Type: Bug
Status: Resolved
Priority: Blocker
Resolution: Fixed
Affects Version/s: 3.0.0-beta1
Fix Version/s: 3.0.0-beta1
Component/s: erasure-coding, metrics
Labels:
- hdfs-ec-3.0-must-do

Target Version/s:

3.0.0-beta1
Hadoop Flags:

Incompatible change
Release Note:

Hide
This renames ClientProtocol#getECBlockGroupsStats to ClientProtocol#getEcBlockGroupStats and ClientProtocol#getBlockStats to ClientProtocol#getReplicatedBlockStats. The return-type classes have also been similarly renamed. Their fields have also been renamed to drop the "stats" suffix.

Additionally, ECBlockGroupStats#pendingDeletionBlockGroups has been renamed to ECBlockGroupStats#pendingDeletionBlocks, to clarify that this is the number of blocks, not block groups, pending deletion. The corresponding NameNode metric has also been renamed to PendingDeletionECBlocks.

Show
This renames ClientProtocol#getECBlockGroupsStats to ClientProtocol#getEcBlockGroupStats and ClientProtocol#getBlockStats to ClientProtocol#getReplicatedBlockStats. The return-type classes have also been similarly renamed. Their fields have also been renamed to drop the "stats" suffix. Additionally, ECBlockGroupStats#pendingDeletionBlockGroups has been renamed to ECBlockGroupStats#pendingDeletionBlocks, to clarify that this is the number of blocks, not block groups, pending deletion. The corresponding NameNode metric has also been renamed to PendingDeletionECBlocks.

Description

Noted in ~~HDFS-12206~~, we should propagate the naming changes made in ~~HDFS-12206~~ for FSNamesystem into BlockManager and related classes. Also an opportunity to clarify usage of "ECBlocks" vs "ECBlockGroups" in some names.