Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-28025

Enhance ByteBufferUtils.findCommonPrefix to compare 8 bytes each time

VotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Reviewed

    Description

      Currently, the `ByteBufferUtils.findCommonPrefix family of methods compare two buffers a single byte at a time. In reviewing the patch for HBASE-28012, Duo Zhang suggested that the ByteBufferUtils.findCommonPrefix methods could be enhanced to compare 8 bytes at a time like the ByteBufferUtils.compareToUnsafe family of methods already does (which was added in HBASE-12345)

      Attachments

        1. benchmark_results.txt
          6 kB
          Becker Ewing
        2. HBASE-28025_jmh_benchmarks_src.zip
          5 kB
          Becker Ewing

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            bewing Becker Ewing
            bewing Becker Ewing
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment