[HBASE-23322] [hbck2] Simplification on HBCKSCP scheduling - ASF JIRA

Voters

Watch issue

Watchers

Link

Clone

Update Comment Author

Replace String in Comment

Update Comment Visibility

Delete Comments

XML

Word

Printable

JSON

Details

Type: Sub-task
Status: Resolved
Priority: Minor
Resolution: Fixed
Affects Version/s: None
Fix Version/s: 3.0.0-alpha-1, 2.3.0, 2.2.3
Component/s: hbck2
Labels:
None

Hadoop Flags:

Reviewed
Release Note:

Hide
An hbck2 scheduleRecoveries will run a subclass of ServerCrashProcedure which asks Master what Regions were on the dead Server but it will also do a hbase:meta table scan to see if any vestiges of the old Server remain (for the case where an SCP failed mid-point leaving references in place or where Master and hbase:meta deviated in accounting).

Show
An hbck2 scheduleRecoveries will run a subclass of ServerCrashProcedure which asks Master what Regions were on the dead Server but it will also do a hbase:meta table scan to see if any vestiges of the old Server remain (for the case where an SCP failed mid-point leaving references in place or where Master and hbase:meta deviated in accounting).

Description

I can make the scheduling of HBCKSCP simpler. I can also fix a bug in parent issue that I notice after exercising it a bunch on a cluster.

The bug is that 'Unknown Servers' seem to be retained in the Map of reporting servers. They are usually cleared just before an SCP is scheduled but scheduling HBCKSCP doesn't go the usual route.

The patch here forces HBCKSCP via the usual SCP route only at the scheduling time, context dictates whether SCP or the scouring HBCKSCP.

Let me put up a patch and will test in meantime.