Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-23258

Reconsider the DBB memory leak in the exceptional paths.

VotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Not A Problem
    • None
    • None
    • None
    • None

    Description

      Have a discussion with Anoop Sam John, we find still have some exceptional paths which we did not handle DBB#release correctly. More details are the following:

      > HFileReaderImpl#validateBlockType - When throws Exception, the get block is gone. Want to return?
      Yeah, we've two cases to validateBlockType. one is reading from cache, another one is reading from hfile. 
      we've abstracted the block for both cache types and hfiles ( ex release the block from heap will donothing), so
      here seems we should do release if throws IOException.
      
      > Only inside another condition we return and evict block
      readBlock - The got block is unused when we throw Exception on DBE type mismatch
      Em..we return null finally , seems the block also need to release the block.
      

      Will take a look around all the exceptional paths and consider any other DBB leak issues.

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            openinx Zheng Hu
            openinx Zheng Hu
            Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment