Uploaded image for project: 'Accumulo'
  1. Accumulo
  2. ACCUMULO-4374

ChangeSecret tool can't accept password input

Log workAgile BoardRank to TopRank to BottomBulk Copy AttachmentsBulk Move AttachmentsVotersWatch issueWatchersCreate sub-taskConvert to sub-taskLinkCloneLabels
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 1.7.3, 1.8.0
    • shell

    Description

      Changes to o.a.a.shell.Shell have broken the ChangeSecret tool. When running o.a.a.server.util.ChangeSecret using the bin/accumulo script, another thread running the Shell will also have an open input stream interfering with the input of the password. This is due to the ServiceLoader creating an instance of the Shell using the no arg constructor, which creates an instance of the jline ConsoleReader.

      There are two options to fix this bug:

      1. Make the no-arg constructor in the Shell do less work. (this should be
      easy, because it's only called by Shell.main, and main can just pass the
      parameters that the no-arg constructor was assuming)
      2. Move the KeywordExecutable stuffs for Shell into a minimal
      launcher/factory class for Shell; see **/MasterExecutable.java for another
      case where I had to do this.

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            milleruntime Michael Miller Assign to me
            milleruntime Michael Miller
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - Not Specified
              Not Specified
              Remaining:
              Remaining Estimate - 0h
              0h
              Logged:
              Time Spent - 1.5h
              1.5h

              Slack

                Issue deployment