Uploaded image for project: 'ZooKeeper'
  1. ZooKeeper
  2. ZOOKEEPER-3675

Clean Up committedLog Interaction in ZKDatabase

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Open
    • Minor
    • Resolution: Unresolved
    • None
    • None
    • None

    Description

      • To be proper, minCommittedLog/maxCommittedLog should only be modified in a lock.
      • maxCommittedLog is potentially set twice (to the same value) for each call to the method
      • Streamline code in addCommittedProposal
      • Pre-initialize committedLog data structure to the full size
      • Remove unused commitLogBuffer
      • Remove synchronization of method getCommittedLog(), it is protected with lock
      • Unify grabbing locks outside of try block
      • Fix off-by-one error in the size of the buffer

      Attachments

        Issue Links

          Activity

            People

              belugabehr David Mollitor
              belugabehr David Mollitor
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 40m
                  40m