Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-4762

C++: Applied some C++11 refactorings to the runtime library and compiler

    XMLWordPrintableJSON

Details

    Description

      I basically used clang-tidy to apply the following C++11 refactorings (which make very much sense to me)

      • make use of override keyword whenever a virtual function is overwritten
      • make use of auto keyword for iterators
      • make use of auto keyword when every a redundancy can be avoided, e.g. 
        uint32_t len = static_cast<uint32_t>(str.length());
        auto len = static_cast<uint32_t>(str.length());
      • replaced NULL with nullptr
      • make use of explicitly-defaulted function definition

      Additionally, I applied some more const-correctness to some functions.

      Attachments

        Issue Links

          Activity

            People

              jking3 James E. King III
              sebastian.zenker Sebastian Zenker
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 20m
                  20m