Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-4759

Minor missing symbol apache::thrift::GlobalOutput for Windows shared library build

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Trivial
    • Resolution: Fixed
    • 0.12.0
    • None
    • C++ - Library
    • None

    Description

      Current trunk has a minor problem when creating a shared library build with cmake on Windows with MSVC 2015 and MSVC 2017. It seems one of the symbols is not defined, even when 
      CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS is on:

      TZlibTransport.cpp.obj : error LNK2001: unresolved external symbol "class apache::thrift::TOutput apache::thrift::GlobalOutput" (?GlobalOutput@thrift@apache@@3VTOutput@12@A)
      bin\thriftzmd.dll : fatal error LNK1120: 1 unresolved externals

      I don't know why this symbols fails for cmake. But if you want to go another route with explicitly exporting all relevant classes, and you need help to create a cmake-based dllimport/dllexport-integration, I can offer some help.

      Attachments

        Issue Links

          Activity

            People

              jking3 James E. King III
              emmenlau Mario Emmenlauer
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 40m
                  40m