Uploaded image for project: 'Apache Storm'
  1. Apache Storm
  2. STORM-3140

Duplicated method in Logviewer REST API?

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Open
    • Major
    • Resolution: Unresolved
    • 2.0.0
    • None
    • storm-webapp
    • None

    Description

          /**
           * Handles '/searchLogs' request.
           */
          @GET
          @Path("/searchLogs")
          public Response searchLogs(@Context HttpServletRequest request) throws IOException {
              String user = httpCredsHandler.getUserName(request);
              String topologyId = request.getParameter("topoId");
              String portStr = request.getParameter("port");
              String callback = request.getParameter("callback");
              String origin = request.getHeader("Origin");
      
              return logviewer.listLogFiles(user, portStr != null ? Integer.parseInt(portStr) : null, topologyId, callback, origin);
          }
      
          /**
           * Handles '/listLogs' request.
           */
          @GET
          @Path("/listLogs")
          public Response listLogs(@Context HttpServletRequest request) throws IOException {
              meterListLogsHttpRequests.mark();
      
              String user = httpCredsHandler.getUserName(request);
              String topologyId = request.getParameter("topoId");
              String portStr = request.getParameter("port");
              String callback = request.getParameter("callback");
              String origin = request.getHeader("Origin");
      
              return logviewer.listLogFiles(user, portStr != null ? Integer.parseInt(portStr) : null, topologyId, callback, origin);
          }

      These two methods are identical although they seem to serve different functions.

      Attachments

        Activity

          People

            Unassigned Unassigned
            zhengdai Zhengdai Hu
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated: