Uploaded image for project: 'Spark'
  1. Spark
  2. SPARK-25075 Build and test Spark against Scala 2.13
  3. SPARK-30009

Replace Ordering.Double with Ordering.Double.TotalOrdering

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 3.0.0
    • 3.0.0
    • Spark Core, SQL
    • None

    Description

      Scala 2.12 replaces Ordering.Double with either of Ordering.Double.TotalOrdering (same behavior, NaN compares consistently) or Ordering.Double.IeeeOrdering (consistent with java.lang.Double.compare, NaN always compares false, for example). Neither is available in both versions, and it doesn't seem like a compat library exists to handle this.

      This can be accomplished by inlining the implementation of Ordering.Double so that both can use it. Or, parallel source trees for 2.12 / 2.13. The latter wouldn't be worth it just for this, but I'm fairly sure a few things will require it anyway.

      Attachments

        Issue Links

          Activity

            People

              srowen Sean R. Owen
              srowen Sean R. Owen
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: