Uploaded image for project: 'Spark'
  1. Spark
  2. SPARK-28958 pyspark.ml function parity
  3. SPARK-29093

Remove automatically generated param setters in _shared_params_code_gen.py

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 3.0.0
    • 3.0.0
    • ML, PySpark
    • Hide
      In Spark 3.0, {{pyspark.ml.param.shared.Has*}} mixins do not provide any {{set*(self, value)}} setter methods anymore, use the respective {{self.set(self.*, value)}} instead. See SPARK-29093 for details.
      Show
      In Spark 3.0, {{pyspark.ml.param.shared.Has*}} mixins do not provide any {{set*(self, value)}} setter methods anymore, use the respective {{self.set(self.*, value)}} instead. See SPARK-29093 for details.

    Description

      The main difference between scala and py sides come from the automatically generated param setter in _shared_params_code_gen.py.

      To make them in sync, we should remove those setters in shared.py, and add the corresponding setters manually.

      Attachments

        Issue Links

          is blocked by

          Sub-task - The sub-task of the issue SPARK-28985 Pyspark ClassificationModel and RegressionModel support column setters/getters/predict

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Sub-task - The sub-task of the issue SPARK-29116 Refactor py classes related to DecisionTree

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Sub-task - The sub-task of the issue SPARK-29142 Pyspark clustering models support column setters/getters/predict

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Sub-task - The sub-task of the issue SPARK-29143 Pyspark feature models support column setters/getters

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          relates to

          Improvement - An improvement or enhancement to an existing feature or task. SPARK-31853 Mention removal of params mixins setter in migration guide

          • Trivial - Cosmetic problem like misspelt words or misaligned text.
          • Resolved
          links to

          Web Link GitHub Pull Request #26232

          Web Link GitHub Pull Request #27397

          Activity

            People

              huaxingao Huaxin Gao
              podongfeng Ruifeng Zheng
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: