Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-9509

Fix problems in shell scripts reported by "shellcheck"

    XMLWordPrintableJSON

Details

    • Task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 9.2
    • scripts and tools

    Description

      Running shellcheck on our shell scripts reveal various improvements we should consider.

      Attachments

        1. SOLR-9509.patch
          25 kB
          Kuro Kurosaka
        2. shellcheck_solr_bin_sh_20160915.txt
          0.2 kB
          Kevin Risden
        3. shellcheck_solr_usr_bin_env_bash_20160915.txt
          14 kB
          Kevin Risden
        4. shellcheck_solr_bin_bash_20160915.txt
          70 kB
          Kevin Risden
        5. shellcheck_solr_20160915.txt
          29 kB
          Kevin Risden
        6. bin_solr_shellcheck.txt
          12 kB
          Jan Høydahl

        Issue Links

          causes

          Bug - A problem which impairs or prevents the functions of the product. SOLR-16755 bin/solr's '-noprompt' option no longer works for examples

          • Major - Major loss of function.
          • Closed
          incorporates

          Improvement - An improvement or enhancement to an existing feature or task. SOLR-15534 Consistently use /usr/bin/env in script shebangs

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open
          links to

          Web Link GitHub Pull Request #1225

          Activity

            People

              janhoy Jan Høydahl
              janhoy Jan Høydahl
              Votes:
              1 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 2h 10m
                  2h 10m