Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-5649

Small ConnectionManager improvements

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 4.6.1
    • 4.7, 6.0
    • SolrCloud
    • None

    Description

      I was just looking through the ConnectionManager and want to jot these down before I forget them. I'm happy to make a patch if someone thinks it's valuable as well.

      • "clientConnected" doesn't seem to be read, can be eliminated
      • "state" is a private volatile variable, but only used in one function – seems unlikely private volatile is what is wanted
      • A comment explaining why disconnected() is not called in the case of Expired would be helpful (Expired means we have already waited the timeout period so we want to reject updates right away)

      Attachments

        1. SOLR-5649.patch
          2 kB
          Mark Miller

        Activity

          People

            markrmiller@gmail.com Mark Miller
            gchanan Gregory Chanan
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: