Uploaded image for project: 'ORC'
  1. ORC
  2. ORC-419

Ensure to call `close` at RecordReaderImpl constructor exception

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Critical
    • Resolution: Fixed
    • 1.5.0, 1.5.1, 1.5.2, 1.5.3
    • 1.5.4, 1.6.0
    • Java
    • None

    Description

      Currently, there is no way to call `RecordReaderImpl.close` if `RecordReader.rows` fails at creating `RecordReaderImpl`. This issue aims to try to invoke `close` in the constructor in case of Exceptions.

        @Override
  public RecordReader rows(Options options) throws IOException {
    LOG.info("Reading ORC rows from " + path + " with " + options);
    return new RecordReaderImpl(this, options);
  }

      Attachments

        Issue Links

          is related to

          Bug - A problem which impairs or prevents the functions of the product. SPARK-23390 Flaky test: FileBasedDataSourceSuite

          • Critical - Crashes, loss of data, severe memory leak.
          • Resolved
          relates to

          Bug - A problem which impairs or prevents the functions of the product. SPARK-25688 Potential resource leak in ORC

          • Critical - Crashes, loss of data, severe memory leak.
          • Resolved
          links to

          Web Link GitHub Pull Request #322

          Web Link GitHub Pull Request #323

          Web Link GitHub Pull Request #324

          Web Link GitHub Pull Request #325

          Activity

            People

              dongjoon Dongjoon Hyun
              dongjoon Dongjoon Hyun
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: