Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-7976

Make TieredMergePolicy respect maxSegmentSizeMB and allow singleton merges of very large segments

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 7.5, master (8.0)
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      We're seeing situations "in the wild" where there are very large indexes (on disk) handled quite easily in a single Lucene index. This is particularly true as features like docValues move data into MMapDirectory space. The current TMP algorithm allows on the order of 50% deleted documents as per a dev list conversation with Mike McCandless (and his blog here: https://www.elastic.co/blog/lucenes-handling-of-deleted-documents).

      Especially in the current era of very large indexes in aggregate, (think many TB) solutions like "you need to distribute your collection over more shards" become very costly. Additionally, the tempting "optimize" button exacerbates the issue since once you form, say, a 100G segment (by optimizing/forceMerging) it is not eligible for merging until 97.5G of the docs in it are deleted (current default 5G max segment size).

      The proposal here would be to add a new parameter to TMP, something like <maxAllowedPctDeletedInBigSegments> (no, that's not serious name, suggestions welcome) which would default to 100 (or the same behavior we have now).

      So if I set this parameter to, say, 20%, and the max segment size stays at 5G, the following would happen when segments were selected for merging:

      > any segment with > 20% deleted documents would be merged or rewritten NO MATTER HOW LARGE. There are two cases,
      >> the segment has < 5G "live" docs. In that case it would be merged with smaller segments to bring the resulting segment up to 5G. If no smaller segments exist, it would just be rewritten
      >> The segment has > 5G "live" docs (the result of a forceMerge or optimize). It would be rewritten into a single segment removing all deleted docs no matter how big it is to start. The 100G example above would be rewritten to an 80G segment for instance.

      Of course this would lead to potentially much more I/O which is why the default would be the same behavior we see now. As it stands now, though, there's no way to recover from an optimize/forceMerge except to re-index from scratch. We routinely see 200G-300G Lucene indexes at this point "in the wild" with 10s of shards replicated 3 or more times. And that doesn't even include having these over HDFS.

      Alternatives welcome! Something like the above seems minimally invasive. A new merge policy is certainly an alternative.

        Attachments

        1. LUCENE-7976.patch
          1 kB
          Michael McCandless
        2. LUCENE-7976.patch
          29 kB
          Erick Erickson
        3. LUCENE-7976.patch
          44 kB
          Erick Erickson
        4. LUCENE-7976.patch
          26 kB
          Erick Erickson
        5. LUCENE-7976.patch
          29 kB
          Erick Erickson
        6. LUCENE-7976.patch
          29 kB
          Erick Erickson
        7. LUCENE-7976.patch
          36 kB
          Erick Erickson
        8. LUCENE-7976.patch
          51 kB
          Erick Erickson
        9. LUCENE-7976.patch
          53 kB
          Erick Erickson
        10. LUCENE-7976.patch
          53 kB
          Erick Erickson
        11. LUCENE-7976.patch
          53 kB
          Erick Erickson
        12. SOLR-7976.patch
          53 kB
          Erick Erickson
        13. LUCENE-7976.patch
          54 kB
          Erick Erickson
        14. LUCENE-7976.patch
          57 kB
          Erick Erickson

          Issue Links

            Activity

              People

              • Assignee:
                erickerickson Erick Erickson
                Reporter:
                erickerickson Erick Erickson
              • Votes:
                7 Vote for this issue
                Watchers:
                25 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: