Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-9147

The E2E tests in min_max_filters.test do not exercise the code paths in min-max-filter.cc

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Open
    • Major
    • Resolution: Unresolved
    • None
    • None
    • Backend
    • None

    Description

      The E2E tests in min_max_filters.test do not exercise the code paths in min-max-filter.cc. This could be verified by commenting out the return statement at https://github.com/apache/impala/blob/master/be/src/util/min-max-filter.cc#L684, and then run the corresponding E2E tests defined in min_max_filters.test.

      $IMPALA_HOME/bin/impala-py.test tests/query_test/test_runtime_filters.py::TestMinMaxFilters::test_min_max_filters
      

      After commenting out that return statement in min-max-filter.cc, we expect to hit a DCHECK at https://github.com/apache/impala/blob/master/be/src/util/min-max-filter.cc#L698. But according to my observation we are not able to hit that DCHECK, implying that the test query at https://github.com/apache/impala/blob/master/testdata/workloads/functional-query/queries/QueryTest/min_max_filters.test#L48-L50 does not trigger the code paths within https://github.com/apache/impala/blob/master/be/src/util/min-max-filter.cc#L655-L699.

      We hence need to improve these E2E tests so that the respective code paths are exercised.

      Attachments

        Activity

          People

            fangyurao Fang-Yu Rao
            fangyurao Fang-Yu Rao
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated: