Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-22692

Use only fixDecimalDataTypePhysicalVariations when vectorizing TopNKey operator

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Not A Problem
    • None
    • 4.0.0-alpha-2
    • None
    • None

    Description

      Currently both 'fixDecimalDataTypePhysicalVariations' and 'getVectorExpressionsUpConvertDecimal64' are called when vectorizing TopNKey operator in 'Vectorizer.java'

          vContext.markActualScratchColumns();
          try {
            List<ExprNodeDesc> keyColumns = topNKeyDesc.getKeyColumns();
      
            keyExpressions = vContext.getVectorExpressionsUpConvertDecimal64(keyColumns);
            fixDecimalDataTypePhysicalVariations(vContext, keyExpressions);
      
          } finally {
            vContext.freeMarkedScratchColumns();
          }
      

      Attachments

        1. HIVE-22692.1.patch
          0.8 kB
          Krisztian Kasa

        Activity

          People

            kkasa Krisztian Kasa
            kkasa Krisztian Kasa
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: