Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-24027

Spotbugs: Return value of putIfAbsent is ignored

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Duplicate
    • None
    • None
    • master
    • None

    Description

      Looks like a regression from HBASE-23561.

      https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1301/2/artifact/yetus-general-check/output/branch-spotbugs-hbase-server-warnings.html

      Return value of putIfAbsent is ignored, but node is reused in org.apache.hadoop.hbase.master.assignment.RegionStates.createRegionStateNode(RegionInfo)
      Bug type RV_RETURN_VALUE_OF_PUTIFABSENT_IGNORED (click for details)
      In class org.apache.hadoop.hbase.master.assignment.RegionStates
      In method org.apache.hadoop.hbase.master.assignment.RegionStates.createRegionStateNode(RegionInfo)
      Called method java.util.concurrent.ConcurrentSkipListMap.putIfAbsent(Object, Object)
      Type org.apache.hadoop.hbase.master.assignment.RegionStateNode
      Value loaded from node
      At RegionStates.java:[line 133]

       

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              weichiu Wei-Chiu Chuang
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: