Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-22274

Cell size limit check on append should consider cell's previous size.

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.0, 2.0.0, 1.3.5
    • Fix Version/s: 3.0.0, 2.2.0, 1.4.10, 2.3.0, 2.1.5
    • Component/s: None
    • Labels:
      None

      Description

      Now we have cell size limit check based on this parameter hbase.server.keyvalue.maxsize 

      One case was missing: appending to a cell only take append op's cell size into account against this limit check. we should check against the potential final cell size after the append.'

      It's easy to reproduce this :

       

      Apply this diff

       

      diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java index 5a285ef6ba..8633177ebe 100644 --- a/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java @@ -6455,7 +6455,7 
      
      
      - t.append(new Append(ROW).addColumn(FAMILY, QUALIFIER, new byte[10 * 1024])); 
      + t.append(new Append(ROW).addColumn(FAMILY, QUALIFIER, new byte[2 * 1024])); 

       

      Fix is to add this check in #reckonDeltas in HRegion class, where we have already got the appended cell's size. 

      Will throw DoNotRetryIOException if checks is failed.

        Attachments

        1. HBASE-22274-branch-1.001.patch
          2 kB
          Xu Cang
        2. HBASE-22274-branch-1.002.patch
          2 kB
          Xu Cang
        3. HBASE-22274-branch-1.003.patch
          38 kB
          Xu Cang
        4. HBASE-22274-branch-1.003.patch
          38 kB
          Xu Cang
        5. HBASE-22274-branch-1.004.patch
          38 kB
          Xu Cang
        6. HBASE-22274-branch-1.005.patch
          2 kB
          Xu Cang
        7. HBASE-22274-master.001.patch
          2 kB
          Xu Cang
        8. HBASE-22274-master.002.patch
          2 kB
          Xu Cang
        9. HBASE-22274-master.002.patch
          2 kB
          Xu Cang
        10. HBASE-22274-master.003.patch
          2 kB
          Xu Cang

          Activity

            People

            • Assignee:
              xucang Xu Cang
              Reporter:
              xucang Xu Cang
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: