Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-21943

The usage of RegionLocations.mergeRegionLocations is wrong for async client

    XMLWordPrintableJSON

    Details

    • Hadoop Flags:
      Reviewed

      Description

      In AsyncRegionLocatorHelper.mergeRegionLocations we create a new RegionLocations and call mergeRegionLocations on it, expected that it will be changed by this method, but actually the method will not modify the object itself, it will return a new one...

      And we are lucky that we create the RegionLocations with the new locations, so usually we will get update result. But when testing HBASE-21717, we meet another bug in AsyncNonMetaRegionLocator.isEqual, where we missed a '!' when checking server name equals...

        Attachments

        1. HBASE-21943.patch
          3 kB
          Duo Zhang
        2. HBASE-21943-UT.patch
          3 kB
          Duo Zhang
        3. HBASE-21943-UT.patch
          3 kB
          Duo Zhang
        4. HBASE-21943-v1.patch
          4 kB
          Duo Zhang
        5. HBASE-21943-UT-v1.patch
          3 kB
          Duo Zhang
        6. HBASE-21943-v2.patch
          14 kB
          Duo Zhang
        7. HBASE-21943-addendum-branch-2.1.patch
          2 kB
          Duo Zhang

          Activity

            People

            • Assignee:
              zhangduo Duo Zhang
              Reporter:
              zhangduo Duo Zhang
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: