Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-21884

Fix box/unbox findbugs warning in secure bulk load

    XMLWordPrintableJSON

Details

    • Task
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 3.0.0-alpha-1, 1.5.0, 2.2.0, 2.1.1, 2.0.3, 2.1.2, 2.0.4, 1.4.10, 1.3.4, 1.2.11, 2.3.0
    • None
    • None

    Description

      
      Reason	Tests
      FindBugs	module:hbase-server
      Boxed value is unboxed and then immediately reboxed in org.apache.hadoop.hbase.security.access.SecureBulkLoadEndpoint.incrementUgiReference(UserGroupInformation) At SecureBulkLoadEndpoint.java:then immediately reboxed in org.apache.hadoop.hbase.security.access.SecureBulkLoadEndpoint.incrementUgiReference(UserGroupInformation) At SecureBulkLoadEndpoint.java:[line 268]
      

      Looking at branch-2 and master I suspect we're doing the same wasteful operation but findbugs can't see it through the lambda definition.

      Attachments

        1. HBASE-21884-branch-1.v0.patch
          3 kB
          Sean Busbey
        2. HBASE-21884-master.v0.patch
          3 kB
          Sean Busbey
        3. HBASE-21884-master.v1.patch
          3 kB
          Sean Busbey

        Issue Links

          Activity

            People

              busbey Sean Busbey
              busbey Sean Busbey
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: