Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-20443

Use checkstyle to ban imports from commons-collections 3

    XMLWordPrintableJSON

Details

    Description

      we upgraded to commons-collections 4 in HBASE-18704 and then to an internal-only hbase-thirdparty version in HBASE-20223, but we've regressed:

      $ git grep "import org.apache.commons.collections"
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/master/BackupLogCleaner.java:import org.apache.commons.collections.MapUtils;
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RowMutations.java:import org.apache.commons.collections.CollectionUtils;
hbase-common/src/main/java/org/apache/hadoop/hbase/util/Bytes.java:import org.apache.commons.collections.CollectionUtils;
hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ZKReplicationQueueStorage.java:import org.apache.commons.collections.CollectionUtils;
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java:import org.apache.commons.collections.CollectionUtils;
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java:import org.apache.commons.collections.CollectionUtils;
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java:import org.apache.commons.collections.CollectionUtils;
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSWALEntry.java:import org.apache.commons.collections.CollectionUtils;
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALSplitter.java:import org.apache.commons.collections.CollectionUtils;
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALSplitter.java:import org.apache.commons.collections.MapUtils;

      we should add the same kind of check as we do for e.g. hadoop annotations.

      Attachments

        1. HBASE-20443.master.002.patch
          1 kB
          Balazs Meszaros
        2. HBASE-20443.master.001.patch
          16 kB
          Balazs Meszaros

        Issue Links

          is blocked by

          Bug - A problem which impairs or prevents the functions of the product. HBASE-20442 clean up incorrect use of commons-collections 3

          • Major - Major loss of function.
          • Resolved
          links to

          Web Link Review Board

          Activity

            People

              meszibalu Balazs Meszaros
              busbey Sean Busbey
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: