Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-20106

API Compliance checker should fall back to specifying origin as remote repo

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.4.0, 1.3.2, 2.0.0, 1.2.7
    • Fix Version/s: 1.3.2, 1.4.3, 2.0.0, 1.2.7
    • Component/s: API, community
    • Labels:
      None

      Description

      Since HBASE-18020 has been in the 1.4.0 release, handling the addendum here.

      Andrew Purtell added a comment - 08/Aug/17 19:34
      Does there need to be a documentation update too. This didn't work for me. On branch-1.4

      ./dev-support/checkcompatibility.py --annotation org.apache.hadoop.hbase.classification.InterfaceAudience.Public --annotation org.apache.hadoop.hbase.classification.InterfaceAudience.LimitedPrivate  --include-file "hbase-*" rel/1.3.1 branch-1.4
      
      INFO:root:Source revision: rel/1.3.1
      INFO:root:Destination revision: branch-1.4
      INFO:root:Applying JAR filename include filter: hbase-*
      INFO:root:Filtering classes using 2 annotation(s):
      INFO:root:	org.apache.hadoop.hbase.classification.InterfaceAudience.Public
      INFO:root:	org.apache.hadoop.hbase.classification.InterfaceAudience.LimitedPrivate
      INFO:root:Downloading Java ACC...
      INFO:root:Removing scratch dir /data/src/hbase/target/compat-check 
      INFO:root:Creating empty scratch dir /data/src/hbase/target/compat-check 
      INFO:root:Checking out 1b8ca49af872b63c7b1fbc20a6fdbe71516dd04c in /data/src/hbase/target/compat-check/src
      INFO:root:Checking out e9e16b59420c5d9a47b9b014b3bb3cb3421b1de9 in /data/src/hbase/target/compat-check/dst
      INFO:root:Building in /data/src/hbase/target/compat-check/src 
      
      ...
      
      INFO:root:Will check compatibility between original jars:
      	/data/src/hbase/target/compat-check/src/hbase-archetypes/hbase-client-project/target/hbase-client-project-1.3.1.jar
      
      ...
      
      and new jars:
      	/data/src/hbase/target/compat-check/dst/hbase-archetypes/hbase-shaded-client-project/target/hbase-shaded-client-project-1.4.0-SNAPSHOT.jar
      
      ...
      
      Traceback (most recent call last):
        File "./dev-support/checkcompatibility.py", line 514, in <module>
          main()
        File "./dev-support/checkcompatibility.py", line 508, in main
          dst_jars, args.annotations, skip_annotations)
        File "./dev-support/checkcompatibility.py", line 283, in run_java_acc
          "-l", get_repo_name(),
        File "./dev-support/checkcompatibility.py", line 126, in get_repo_name
          cwd=get_repo_dir()).strip()
        File "./dev-support/checkcompatibility.py", line 71, in check_output
          raise error
      subprocess.CalledProcessError: Command '['git', 'config', '--get', 'remote.origin.url']' returned non-zero exit status 1
      
      [apurtell@ip-172-31-47-35 hbase]$ git --version
      git version 1.7.1
      

      awleblang Alex Leblang added a comment - 05/Sep/17 08:47
      For some reason, perhaps due to the change from bash to python, the code needed to explicitly state "origin/branch_name" on clean checkouts. I went back to look at the bash version and we use the same command, git rev-parse, so I'm not sure why this only just starting failing but this fixed the issue in all cases where I was able to replicate the failure

        Attachments

        1. HBASE-20106.0.patch
          1 kB
          Sean Busbey

          Activity

            People

            • Assignee:
              awleblang Alex Leblang
              Reporter:
              busbey Sean Busbey
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: