Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-18169 Coprocessor fix and cleanup before 2.0.0 release
  3. HBASE-19048

Cleanup MasterObserver hooks which takes IA private params

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 2.0.0-alpha-4, 2.0.0
    • Coprocessors
    • None
    • Reviewed
    • Hide
      Purged InterfaceAudience.Private parameters from methods in MasterObserver.

      preAbortProcedure no longer takes a ProcedureExecutor.

      postGetProcedures no longer takes a list of Procedures.

      postGetLocks no longer takes a list of locks.

      preRequestLock and postRequestLock no longer take lock type.

      preLockHeartbeat and postLockHeartbeat no longer takes a lock procedure.

      The implication is that that the Coprocessors that depended on these params have had to coarsen so for example, the AccessController can not do access per Procedure or Lock but rather, makes a judgement on the general access (You'll need to be ADMIN to see list of procedures and locks).
      Show
      Purged InterfaceAudience.Private parameters from methods in MasterObserver. preAbortProcedure no longer takes a ProcedureExecutor. postGetProcedures no longer takes a list of Procedures. postGetLocks no longer takes a list of locks. preRequestLock and postRequestLock no longer take lock type. preLockHeartbeat and postLockHeartbeat no longer takes a lock procedure. The implication is that that the Coprocessors that depended on these params have had to coarsen so for example, the AccessController can not do access per Procedure or Lock but rather, makes a judgement on the general access (You'll need to be ADMIN to see list of procedures and locks).

    Description

      These are the ones in MasterObserver

      		preAbortProcedure	 -  ProcedureExecutor
		postGetProcedures	 - Procedure
		postGetLocks		 - LockedResource
		preRequestLock	 - LockType
		postRequestLock	 - LockType
		preLockHeartbeat	 - LockProcedure
		postLockHeartbeat	 - LockProcedure

      Attachments

        1. HBASE-19048.master.003.patch
          19 kB
          Michael Stack
        2. HBASE-19048.master.003.patch
          19 kB
          Michael Stack
        3. HBASE-19048.master.002.patch
          45 kB
          Michael Stack
        4. HBASE-19048.master.001.patch
          46 kB
          Michael Stack

        Issue Links

          relates to

          Sub-task - The sub-task of the issue HBASE-19093 Check Admin/Table to ensure all operations go via AccessControl

          • Blocker - Blocks development and/or testing work, production could not run
          • Resolved
          links to

          Web Link Review Board (master)

          Activity

            People

              stack Michael Stack
              anoop.hbase Anoop Sam John
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: