Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-18169 Coprocessor fix and cleanup before 2.0.0 release
  3. HBASE-18906

Provide Region#waitForFlushes API

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Closed
    • Critical
    • Resolution: Fixed
    • None
    • 2.0.0-alpha-4, 2.0.0
    • Coprocessors
    • None
    • Reviewed
    • Hide
      Provided an API in Region (Exposed to CPs)
      boolean waitForFlushes(long timeout)
      This call will make the current thread to be waiting for all flushes in this region to be finished. (Upto the time out time being specified). The boolean return value specify whether the flushes are really over or the time out being elapsed. Return false when timeout elapsed but flushes are not over or true when flushes are over
      Show
      Provided an API in Region (Exposed to CPs) boolean waitForFlushes(long timeout) This call will make the current thread to be waiting for all flushes in this region to be finished. (Upto the time out time being specified). The boolean return value specify whether the flushes are really over or the time out being elapsed. Return false when timeout elapsed but flushes are not over or true when flushes are over

    Description

      Expose an API for the CPs to wait for all on going flushes in a Region. The API should support taking a time out.

      Background
      While reviewing HBASE-18183, Andy pointed out that Phoenix uses waitForFlushesAndCompactions and/or waitForFlushes for diff reasons. This issue is to see why they need them and whether alternate ways are possible. This seems to be too much internal stuff and a normal CP hook calling these would be dangerous.
      If there are alternate ways for Phoenix not to use this and not landing in issues (As said by Andy) we should suggest/fix for them.

      Attachments

        1. HBASE-18906.patch
          3 kB
          Anoop Sam John
        2. HBASE-18906_V2.patch
          3 kB
          Anoop Sam John
        3. HBASE-18906_V2.patch
          3 kB
          Michael Stack

        Issue Links

          is related to

          Sub-task - The sub-task of the issue HBASE-18905 Allow CPs to request flush on Region and know the completion of the requested flush

          • Major - Major loss of function.
          • Closed
          relates to

          Sub-task - The sub-task of the issue HBASE-18989 Polish the compaction related CP hooks

          • Major - Major loss of function.
          • Closed

          Activity

            People

              anoop.hbase Anoop Sam John
              anoop.hbase Anoop Sam John
              Votes:
              0 Vote for this issue
              Watchers:
              13 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: