Details
-
Bug
-
Status: Resolved
-
Critical
-
Resolution: Fixed
-
2.0.0
-
None
-
Reviewed
Description
This is comments for KeyValueScanner.getScannerOrder
KeyValueScanner.java
/** * Get the order of this KeyValueScanner. This is only relevant for StoreFileScanners and * MemStoreScanners (other scanners simply return 0). This is required for comparing multiple * files to find out which one has the latest data. StoreFileScanners are ordered from 0 * (oldest) to newest in increasing order. MemStoreScanner gets LONG.max since it always * contains freshest data. */ long getScannerOrder();
As now we may have multiple memstore scanners, I think the right way to select scanner order for memstore scanner is to ordered from Long.MAX_VALUE in decreasing order.
But in CompactingMemStore and DefaultMemStore, the scanner order for memstore scanner is also start from 0, which will be messed up with StoreFileScanners.
Attachments
Attachments
Issue Links
- links to