Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-16769

Deprecate/remove PB references from MasterObserver and RegionServerObserver

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Blocker
    • Resolution: Fixed
    • None
    • 2.0.0-alpha-4, 2.0.0
    • None
    • None
    • Incompatible change, Reviewed
    • Hide
      Signature of below methods in MasterObserver changed and instead of org.apache.hadoop.hbase.shaded.protobuf.generated.SnapshotDescription param, we will be passing org.apache.hadoop.hbase.client.SnapshotDescription
      preListSnapshot
      postListSnapshot
      preSnapshot
      postSnapshot
      preCloneSnapshot
      postCloneSnapshot
      preRestoreSnapshot
      postRestoreSnapshot
      preDeleteSnapshot
      postDeleteSnapshot

      Also changed signature of RegionServerObserver#preReplicateLogEntries and preReplicateLogEntries by removing params List<org.apache.hadoop.hbase.shaded.protobuf.generated.AdminProtos.WALEntry>, org.apache.hadoop.hbase.CellScanner
      Show
      Signature of below methods in MasterObserver changed and instead of org.apache.hadoop.hbase.shaded.protobuf.generated.SnapshotDescription param, we will be passing org.apache.hadoop.hbase.client.SnapshotDescription preListSnapshot postListSnapshot preSnapshot postSnapshot preCloneSnapshot postCloneSnapshot preRestoreSnapshot postRestoreSnapshot preDeleteSnapshot postDeleteSnapshot Also changed signature of RegionServerObserver#preReplicateLogEntries and preReplicateLogEntries by removing params List<org.apache.hadoop.hbase.shaded.protobuf.generated.AdminProtos.WALEntry>, org.apache.hadoop.hbase.CellScanner

    Description

      This is effectively a sub-task for HBASE-15174.
      CP Methods
      MasterObserver
      preListSnapshot
      postListSnapshot
      preSnapshot
      postSnapshot
      preCloneSnapshot
      postCloneSnapshot
      preRestoreSnapshot
      postRestoreSnapshot
      preDeleteSnapshot
      postDeleteSnapshot

      preSetUserQuota
      postSetUserQuota
      preSetUserQuota
      postSetUserQuota
      preSetUserQuota
      postSetUserQuota
      preSetTableQuota
      postSetTableQuota
      preSetNamespaceQuota
      postSetNamespaceQuota

      RegionServerObserver
      preReplicateLogEntries
      postReplicateLogEntries

      Note : This issue not handling Quota related CPs. Same is handled by a subtask here HBase-18807

      Attachments

        1. HBASE-16769_V2.patch
          32 kB
          Anoop Sam John
        2. HBASE-16769_V4.patch
          33 kB
          Anoop Sam John
        3. HBASE-16769.patch
          32 kB
          Anoop Sam John

        Issue Links

          is part of

          Sub-task - The sub-task of the issue HBASE-15174 Client Public API should not have PB objects in 2.0

          • Blocker - Blocks development and/or testing work, production could not run
          • Closed
          is related to

          Bug - A problem which impairs or prevents the functions of the product. HBASE-15638 Shade protobuf

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. HBASE-15607 Remove PB references from Admin for 2.0

          • Blocker - Blocks development and/or testing work, production could not run
          • Closed
          relates to

          Sub-task - The sub-task of the issue HBASE-18873 Hide protobufs in GlobalQuotaSettings

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. HBASE-18169 Coprocessor fix and cleanup before 2.0.0 release

          • Blocker - Blocks development and/or testing work, production could not run
          • Closed

          Activity

            People

              anoop.hbase Anoop Sam John
              anoop.hbase Anoop Sam John
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: