Uploaded image for project: 'Cassandra'
  1. Cassandra
  2. CASSANDRA-7066

Simplify (and unify) cleanup of compaction leftovers

    XMLWordPrintableJSON

Details

    Description

      Currently we manage a list of in-progress compactions in a system table, which we use to cleanup incomplete compactions when we're done. The problem with this is that 1) it's a bit clunky (and leaves us in positions where we can unnecessarily cleanup completed files, or conversely not cleanup files that have been superceded); and 2) it's only used for a regular compaction - no other compaction types are guarded in the same way, so can result in duplication if we fail before deleting the replacements.

      I'd like to see each sstable store in its metadata its direct ancestors, and on startup we simply delete any sstables that occur in the union of all ancestor sets. This way as soon as we finish writing we're capable of cleaning up any leftovers, so we never get duplication. It's also much easier to reason about.

      Attachments

        1. 7066.txt
          2 kB
          Benedict Elliott Smith

        Issue Links

          breaks

          Sub-task - The sub-task of the issue CASSANDRA-10105 Windows dtest 3.0: TestOfflineTools failures

          • Normal -
          • Resolved

          Sub-task - The sub-task of the issue CASSANDRA-10109 Windows dtest 3.0: ttl_test.py failures

          • Normal -
          • Resolved
          contains

          Improvement - An improvement or enhancement to an existing feature or task. CASSANDRA-9854 Make CompactionController.maybeRefreshOverlaps public

          • Normal -
          • Resolved
          is related to

          Bug - A problem which impairs or prevents the functions of the product. CASSANDRA-10006 2.1 format sstable filenames with "tmp" are not handled by 3.0

          • Normal -
          • Resolved

          Improvement - An improvement or enhancement to an existing feature or task. CASSANDRA-6756 Provide option to avoid loading orphan SSTables on startup

          • Normal -
          • Resolved
          relates to

          Bug - A problem which impairs or prevents the functions of the product. CASSANDRA-10421 Potential issue with LogTransaction as it only checks in a single directory for files

          • Urgent - This issue should block release until it is resolved, and trigger immediate release once resolved.
          • Resolved

          Improvement - An improvement or enhancement to an existing feature or task. CASSANDRA-9516 ViewTest.testSSTablesInBounds fails in trunk

          • Normal -
          • Resolved

          Improvement - An improvement or enhancement to an existing feature or task. CASSANDRA-10112 Refuse to start and print txn log information in case of disk corruption

          • Normal -
          • Resolved

          Improvement - An improvement or enhancement to an existing feature or task. CASSANDRA-8271 Remove SSTableDeletingTask

          • Low -
          • Resolved
          links to

          Web Link additional 3.0 patch

          Web Link initial-trunk-patch

          Web Link Standalone tool dtests

          Activity

            People

              stefania Stefania Alborghetti
              benedict Benedict Elliott Smith
              Stefania Alborghetti
              Benedict Elliott Smith
              Votes:
              0 Vote for this issue
              Watchers:
              16 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: