[CASSANDRA-14834] Avoid keeping StreamingTombstoneHistogramBuilder.Spool in memory during the whole compaction - ASF JIRA

XML

Word

Printable

JSON

Details

Type: Bug
Status: Resolved
Priority: Low
Resolution: Fixed
Fix Version/s: 4.0-rc1, 4.0
Component/s: Local/Compaction
Labels:
None

Severity:
Low
Complexity:
Normal
Since Version:

4.0-alpha1
Source Control Link:

https://github.com/apache/cassandra/commit/5e8f7f591dfec5a61d8eb2e9e977ec29f3a2bbe4
Test and Documentation Plan:

Hide

No doc.
I didn't come with a test that would prove that we would not OOM because of this. I'm open to suggestions.

Show
No doc. I didn't come with a test that would prove that we would not OOM because of this. I'm open to suggestions.

Description

Since ~~CASSANDRA-13444~~ StreamingTombstoneHistogramBuilder.Spool is allocated to keep around an array with 131072 * 2 * 2 integers per written sstable during the whole compaction. With LCS at times creating 1000s of sstables during a compaction it kills the node.

Attachments

Activity

People

Assignee:: Adam Holmberg

Reporter:: Marcus Eriksson

Authors:: Adam Holmberg

Reviewers:: Berenguer Blasi, Michael Semb Wever

Votes:: 0 Vote for this issue

Watchers:: 11 Start watching this issue

Dates

Created:: 19/Oct/18 14:28

Updated:: 20/Jan/21 22:28

Resolved:: 20/Jan/21 22:28