Uploaded image for project: 'Beam'
  1. Beam
  2. BEAM-9252

Problem shading Beam pipeline with Beam 2.20.0-SNAPSHOT

Details

    • Bug
    • Status: Resolved
    • P1
    • Resolution: Fixed
    • 2.20.0
    • 2.20.0
    • build-system
    • None

    Description

      I was checking today a pipeline against the latest 2.20.0-SNAPSHOT and I found that it works perfectly with version 2.19.0, but it is failing with a  shade related exception that refers to grpc 1.26.0:

      [ERROR] Failed to execute goal org.apache.maven.plugins:maven-shade-plugin:3.2.1:shade (default) on project EventsToIOs: Error creating shaded jar: Problem shading JAR /home/ismael/.m2/repository/org/apache/beam/beam-vendor-grpc-1_26_0/0.1/beam-vendor-grpc-1_26_0-0.1.jar entry org/apache/beam/vendor/grpc/v1p26p0/org/jboss/modules/Main.class: org.apache.maven.plugin.MojoExecutionException: Error in ASM processing class org/apache/beam/vendor/grpc/v1p26p0/org/jboss/modules/Main.class: 65536 -> [Help 1]

      There is also a warning that is not present in the build against 2.19.0

      [WARNING] Discovered module-info.class. Shading will break its strong encapsulation.

       

      I wonder if we are not doing something wrong during our vendoring, can someone take a look please.

      This is relatively easy to reproduce with the beam-samples repo, just clone it and run:

      git clone https://github.com/jbonofre/beam-samples
      mvn clean verify -Pbeam-release-repo -Dbeam.version=2.20.0-SNAPSHOT
      

      Available logs of the latest run:

      https://github.com/jbonofre/beam-samples/runs/427537544?check_suite_focus=true

       

      Attachments

        1. ArrayIndexOutOfBoundsException.png
          471 kB
          Tomo Suzuki
        2. image-2020-02-21-13-22-01-341.png
          471 kB
          Tomo Suzuki

        Issue Links

          Activity

            People

              lcwik Luke Cwik
              iemejia Ismaël Mejía
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 3.5h
                  3.5h