Details
-
Bug
-
Status: Resolved
-
P3
-
Resolution: Fixed
-
None
-
None
Description
Without getting into a question whether 80 is a reasonable limit, what are the reasons to treat type annotations differently than other parts of Python code (including comments), which have a 80 character limit?
Places that need to be fixed (PR coming):
```
> Task :sdks:python:test-suites:tox:py37:lintPy37 ************* Module apache_beam.testing.test_stream_it_test apache_beam/testing/test_stream_it_test.py:50:0: C0301: Line too long (106/80) (line-too-long) ************* Module apache_beam.io.filesystems apache_beam/io/filesystems.py:99:0: C0301: Line too long (101/80) (line-too-long) apache_beam/io/filesystems.py:100:0: C0301: Line too long (111/80) (line-too-long) ************* Module apache_beam.runners.portability.fn_api_runner apache_beam/runners/portability/fn_api_runner.py:115:0: C0301: Line too long (114/80) (line-too-long) ************* Module apache_beam.transforms.core apache_beam/transforms/core.py:1307:0: C0301: Line too long (116/80) (line-too-long) apache_beam/transforms/core.py:2271:0: C0301: Line too long (95/80) (line-too-long) apache_beam/transforms/core.py:2272:0: C0301: Line too long (90/80) (line-too-long) ************* Module setup setup.py:141:0: C0301: Line too long (81/80) (line-too-long) ------------------------------------
Attachments
Issue Links
- links to