Uploaded image for project: 'Beam'
  1. Beam
  2. BEAM-7996

Add support for remaining data types in python RowCoder

Details

    • New Feature
    • Status: Open
    • P1
    • Resolution: Unresolved
    • None
    • None
    • cross-language, sdk-py-core
    • None

    Description

      In the initial python RowCoder implementation we only added support for the data types that already had coders in the Python SDK. We should add support for the remaining data types that are not currently supported:

      • INT8 (ByteCoder in Java)
      • INT16 (BigEndianShortCoder in Java)
      • FLOAT (FloatCoder in Java) (Note: doubles are supported, this is specifically for single-precision)
      • -BOOLEAN (standard beam:coder:bool:v1, BooleanCoder in Java)-
      • -BYTES (standard beam:coder:bytes:v1, ByteArrayCoder in Java)-
      • -Map (MapCoder in Java)-

      We might consider making those coders standard so they can be tested independently from RowCoder in standard_coders.yaml. Or, if we don't do that we should probably add a more robust testing framework for RowCoder itself, because it will be challenging to test all of these types as part of the RowCoder tests in standard_coders.yaml.

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              bhulette Brian Hulette
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 9h 20m
                  9h 20m